Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial state file example in docs #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qiongwu-git
Copy link

@qiongwu-git qiongwu-git commented Mar 16, 2020

Description of change

The documentation of the initial state file and the configuration file are incomplete or wrong and should contain all options the tap software provides.

Manual QA steps

  • the state.json does not affect the report synchronization even though it should

Risks

  • none

Rollback steps

  • revert this branch

* fix the initial state file example
* add information about conversion window days in config file
* add information about start date for each stream in initial state file
@cmerrick
Copy link
Contributor

Hi @qiongwu-git, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @qiongwu-git!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants